Hi guys, On Thu, Dec 17, 2020 at 05:39:45PM +0100, Tim Düsterhus wrote: > Ilya, > > [Willy: Note for you below] > > Am 17.12.20 um 10:01 schrieb ???? ???????: > > well, I met some projects that are insane on formatting. > > it is funny each time, when discussing new PR "please fix your formatting" > > (weeks spent on that), after PR is merged something is broken because of > > lack of testing. > > This is not about arbitrary formatting (Tabs vs Spaces or the bracing > style), but this is about *actually* misleading indentation. > > Misleading indentation is something that actually caused security > relevant bugs in other projects in the past. 'goto fail' would be an > example. > > This warning is good, it found an actual issue. It must stay.
Indeed, while I hate when compilers complain about style, this category of bugs can keep you awake very late at night! > > Willy: > > Can you please check line 236 in plock.h (__pl_r = 0;). It is > misleadingly intended. In fact I believe the line might not be > necessary, because `__pl_r` should already be 0 after exiting the > `while` loop. Agreed, it's definitely a leftover of some previous code and makes no sense. I'll deal with it, thanks to you both for this report! Willy
