OK I see. I had some thoughts on merging the tests. Are we going to merge several tests into a single file (thus losing their histories) or we will add a digit to the names and put into the same folder?
For example we have math tests from at least 3 sources and currently some of the tests are of several megabytes long. Are we going to mix all them into a single file? Thanks, Mikhail 2006/5/11, George Harley <[EMAIL PROTECTED]>:
Mikhail Loenko wrote: > George > > Is there any reason to make this changes now rather then complete > discussion > around the tests layout? > > Thanks, > Mikhail Hi Mikhail, Good point, I should have referenced that discussion. My proposed changes are not intended to be the last word on the tests layout but more an attempt to tidy up the tests into a smaller set of packages so that it is hopefully easier to make the agreed changes in the future. For instance, we presently have a number of test classes in different packages (but with the same base name) that are testing the same API types - I think there is value in merging these scattered tests together so that we can all see precisely where the tests for a given public API type should go. This will hopefully make it easier for folks to supply patches that include unit test code as it removes any possible ambiguities about which unit test class should contain the changes. It would remove something I have seen a few times where separate JIRA reports fixing bugs in a particular type supply unit test changes to different test classes. Best regards, George > > 2006/5/11, George Harley <[EMAIL PROTECTED]>: >> Hi, >> >> Just a heads up to you all (and especially anyone working in beans just >> now) that I would like to make some changes to src/tests in the beans >> module in the next day or so. Proposed changes are similar to the tidy >> ups that have taken place in archive, jndi, rmi, logging, prefs etc over >> the last few weeks and consist of ... >> >> * under the src/test/java source folder, merge all of the API tests into >> one package structure under org.apache.harmony.beans.tests. So we get >> o.a.h.b.t.java.beans and o.a.h.b.t.java.beans.beancontext etc. >> >> * move the relatively small number of tests that rely on running on the >> bootclasspath to under src/test/java-internal which get compiled to >> bin/test-internal. >> >> * in the run.tests target of make/common/build.xml have a junit task >> that runs the internal tests on the bootclasspath and another junit test >> that runs the API/non-internal tests on the classpath. >> >> >> Please holler if you are about to make any changes in this area. >> Otherwise I will proceed when/if SVN becomes available for me again. >> >> >> Best regards, >> George >> >> >> >> >> >> >> >> >> --------------------------------------------------------------------- >> Terms of use : http://incubator.apache.org/harmony/mailing.html >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
