On 3 August 2006 at 21:36, "Andrew Zhang" <[EMAIL PROTECTED]> wrote: > > On 8/3/06, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote: > > > > Paulex Yang wrote: > > > Andrew Zhang wrote: > > >> The failure is caused by Harmony-1040. > > >> The updated hostEquals(URL u1, URL u2) introduces a new bug: > > >> It returns true when u1.host = null and u2.host = "" while it should > > >> return > > >> false. > > > > > >> Sorry for the mistake caused by my patch. I'll update a new patch to > > >> solve this problem.
Ideally we should also add a regression test to luni to catch this problem. The fact that the problem wasn't caught means the current luni don't have sufficient coverage so adding a test to luni would help improve this. I think we should always try to do this when a change in a module passes that modules tests but fails another modules tests (as long as it is reasonably practical to do so). Regards, Mark. > > > Great, thank you to find this, Andrew. And don't need to say sorry, it's > > > me who takes responsibility on this and then owes the beer:-(. > > > > Out of curiosity, did either of you run the test suite on windows before > > offering the patch or committing it? This isn't about "blame" or such, > > but about learning about how to make a better process.... > > > I did run luni and nio module test on both windows and linux, but security > module fails... > > It's a lesson for me. I'll pay more attention next time. > > > > > There's no harm done - it was found fast, and fixed fast, so kudos to > > you guys for working together on that. > > > > geir --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
