> On 2012-05-05 01:54:53, Francis Liu wrote: > > /trunk/src/java/org/apache/hcatalog/api/HCatHMSImpl.java, line 569 > > <https://reviews.apache.org/r/4940/diff/3/?file=106118#file106118line569> > > > > if we don't set it what will happen? will hms set it for us?
The HMS does not set it, "convertToMTable" in ObjectStore.java (hive) just gets the table creation time and set it. So if we do not set it, there will be no value. > On 2012-05-05 01:54:53, Francis Liu wrote: > > /trunk/src/java/org/apache/hcatalog/api/HCatHMSImpl.java, line 332 > > <https://reviews.apache.org/r/4940/diff/3/?file=106118#file106118line332> > > > > same with this logic. These are some basic checks that hive is also doing before passing the command to the hive metastore. Instead of letting the call go to server and then fail, it could fail in the client itself. - Vandana ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4940/#review7587 ----------------------------------------------------------- On 2012-05-11 01:09:13, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4940/ > ----------------------------------------------------------- > > (Updated 2012-05-11 01:09:13) > > > Review request for hcatalog, Francis Liu, David Capwell, and Rohini > Palaniswamy. > > > Summary > ------- > > HCatalog java APIs for DDL commands. > > > Diffs > ----- > > /trunk/src/java/org/apache/hcatalog/api/HCatAddPartitionDesc.java > PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatClient.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatClientHMSImpl.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatCreateDBDesc.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatCreateTableDesc.java > PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatDatabase.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatPartition.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatTable.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1336918 > /trunk/src/java/org/apache/hcatalog/data/schema/HCatFieldSchema.java > 1336918 > /trunk/src/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java > 1336918 > /trunk/src/test/org/apache/hcatalog/api/TestHCatClient.java PRE-CREATION > > Diff: https://reviews.apache.org/r/4940/diff > > > Testing > ------- > > Unit test passes. > > TODO: > > - cover more test cases. > - E2E tests. > > > Thanks, > > Vandana > >
