----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4940/#review8071 -----------------------------------------------------------
/trunk/src/java/org/apache/hcatalog/api/HCatAddPartitionDesc.java <https://reviews.apache.org/r/4940/#comment17568> Lot of places hcat is spelled as "h cat". /trunk/src/java/org/apache/hcatalog/api/HCatClient.java <https://reviews.apache.org/r/4940/#comment17570> mode can be a enum /trunk/src/java/org/apache/hcatalog/api/HCatClient.java <https://reviews.apache.org/r/4940/#comment17572> typo. should be partition is /trunk/src/java/org/apache/hcatalog/api/HCatClient.java <https://reviews.apache.org/r/4940/#comment17573> typo in kvs. Would be good if more details was given in the javadoc for partKVs /trunk/src/java/org/apache/hcatalog/api/HCatClientHMSImpl.java <https://reviews.apache.org/r/4940/#comment17569> The HiveConf can be a local variable initialized in the constructor. /trunk/src/java/org/apache/hcatalog/api/HCatClientHMSImpl.java <https://reviews.apache.org/r/4940/#comment17574> Should we check for null also? - Rohini On 2012-05-23 23:44:24, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4940/ > ----------------------------------------------------------- > > (Updated 2012-05-23 23:44:24) > > > Review request for hcatalog, Francis Liu, David Capwell, and Rohini > Palaniswamy. > > > Summary > ------- > > HCatalog java APIs for DDL commands. > > > This addresses bug hcatalog-419. > https://issues.apache.org/jira/browse/hcatalog-419 > > > Diffs > ----- > > /trunk/src/java/org/apache/hcatalog/api/HCatAddPartitionDesc.java > PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatClient.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatClientHMSImpl.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatCreateDBDesc.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatCreateTableDesc.java > PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatDatabase.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatPartition.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatTable.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1336918 > /trunk/src/java/org/apache/hcatalog/data/schema/HCatFieldSchema.java > 1336918 > /trunk/src/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java > 1336918 > /trunk/src/test/org/apache/hcatalog/api/TestHCatClient.java PRE-CREATION > > Diff: https://reviews.apache.org/r/4940/diff > > > Testing > ------- > > Unit test passes. > > TODO: > > - cover more test cases. > - E2E tests. > > > Thanks, > > Vandana > >
