----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4940/#review8131 -----------------------------------------------------------
/trunk/src/java/org/apache/hcatalog/api/HCatClientHMSImpl.java <https://reviews.apache.org/r/4940/#comment17653> The StringUtils.IsEmpty checks for null too. public static boolean isEmpty(String str) { return ((str == null) || (str.length() == 0)); } - Vandana On 2012-05-23 23:44:24, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4940/ > ----------------------------------------------------------- > > (Updated 2012-05-23 23:44:24) > > > Review request for hcatalog, Francis Liu, David Capwell, and Rohini > Palaniswamy. > > > Summary > ------- > > HCatalog java APIs for DDL commands. > > > This addresses bug hcatalog-419. > https://issues.apache.org/jira/browse/hcatalog-419 > > > Diffs > ----- > > /trunk/src/java/org/apache/hcatalog/api/HCatAddPartitionDesc.java > PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatClient.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatClientHMSImpl.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatCreateDBDesc.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatCreateTableDesc.java > PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatDatabase.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatPartition.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/api/HCatTable.java PRE-CREATION > /trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1336918 > /trunk/src/java/org/apache/hcatalog/data/schema/HCatFieldSchema.java > 1336918 > /trunk/src/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java > 1336918 > /trunk/src/test/org/apache/hcatalog/api/TestHCatClient.java PRE-CREATION > > Diff: https://reviews.apache.org/r/4940/diff > > > Testing > ------- > > Unit test passes. > > TODO: > > - cover more test cases. > - E2E tests. > > > Thanks, > > Vandana > >
