----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6494/#review10556 -----------------------------------------------------------
It looks good, can you rebase the patch so I can try it out. - Francis Liu On Aug. 9, 2012, 4:49 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6494/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2012, 4:49 p.m.) > > > Review request for hcatalog and Francis Liu. > > > Description > ------- > > hcatalog-server-extensions.jar is an existing artifact we provide. This > change refactors the repo layout & build so that server-extensions is a new > subproject with its own Ivy dependencies. > > The benefit is users who do not need the server extensions do not pull JMS & > other transitive dependencies into their project. > > > This addresses bug HCATALOG-461. > https://issues.apache.org/jira/browse/HCATALOG-461 > > > Diffs > ----- > > build.xml 4da0cff > ivy.xml 703f6ec > server-extensions/build.xml PRE-CREATION > server-extensions/ivy.xml PRE-CREATION > > server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java > PRE-CREATION > > server-extensions/src/test/java/org/apache/hcatalog/listener/TestMsgBusConnection.java > PRE-CREATION > > server-extensions/src/test/java/org/apache/hcatalog/listener/TestNotificationListener.java > PRE-CREATION > src/java/org/apache/hcatalog/listener/NotificationListener.java 63775f7 > src/test/org/apache/hcatalog/listener/TestMsgBusConnection.java 4da3cef > src/test/org/apache/hcatalog/listener/TestNotificationListener.java 7d09d79 > > Diff: https://reviews.apache.org/r/6494/diff/ > > > Testing > ------- > > > Thanks, > > Travis Crawford > >
