----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6494/#review11224 -----------------------------------------------------------
Sorry for the delay, tried the patch it doesn't apply cleanly. It seems that the core jar will still use ivy for dependencies? Would be better if it was a pom as well. BTW will profiles work? I'll need to add profiles for the different hadoop builds (0.23, 1.0, 2.x). As the original plan to just create shims for the the builds isn't practical. build.xml <https://reviews.apache.org/r/6494/#comment24165> we originally didn't include server-extensions in the fat jar? Is there a reason why we're doing this now? - Francis Liu On Aug. 31, 2012, 10:34 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6494/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2012, 10:34 p.m.) > > > Review request for hcatalog and Francis Liu. > > > Description > ------- > > hcatalog-server-extensions.jar is an existing artifact we provide. This > change refactors the repo layout & build so that server-extensions is a new > subproject with its own Ivy dependencies. > > The benefit is users who do not need the server extensions do not pull JMS & > other transitive dependencies into their project. > > > This addresses bug HCATALOG-461. > https://issues.apache.org/jira/browse/HCATALOG-461 > > > Diffs > ----- > > ant/deploy.xml 84c3648 > build-common.xml ac9b4f5 > build.xml 76b8cb4 > hcatalog-pig-adapter/build.xml 8dbc319 > ivy.xml 11e45bf > server-extensions/build.xml PRE-CREATION > server-extensions/pom.xml PRE-CREATION > > server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java > PRE-CREATION > > server-extensions/src/test/java/org/apache/hcatalog/listener/TestMsgBusConnection.java > PRE-CREATION > > server-extensions/src/test/java/org/apache/hcatalog/listener/TestNotificationListener.java > PRE-CREATION > src/java/org/apache/hcatalog/listener/NotificationListener.java 8529c5a > src/test/org/apache/hcatalog/listener/TestMsgBusConnection.java 4da3cef > src/test/org/apache/hcatalog/listener/TestNotificationListener.java 7d09d79 > webhcat/java-client/build.xml fc1386c > webhcat/svr/build.xml a7bc34c > > Diff: https://reviews.apache.org/r/6494/diff/ > > > Testing > ------- > > > Thanks, > > Travis Crawford > >
