> On Sept. 10, 2012, 12:53 a.m., Francis Liu wrote: > > build.xml, line 200 > > <https://reviews.apache.org/r/6494/diff/2/?file=148794#file148794line200> > > > > we originally didn't include server-extensions in the fat jar? Is there > > a reason why we're doing this now? > > Travis Crawford wrote: > This looks like a bug. I need to update this patch after the spacing > patch went in, and will fix this.
Hey Francis - I took another look at this and believe we do include server-extensions in the fat jar. The "clientjar" bundles all "build.classes", but the server-extensions jar has a filter to just grab the subset of classes. So far with the fat jar we've been keeping it as-is, and will stop producing at some point. Do you think I should remove the server extensions from the fat jar now or leave as-is? http://svn.apache.org/viewvc/incubator/hcatalog/trunk/build.xml?view=markup 162 <target name="clientjar" depends="compile-src"> 163 <jar jarfile="${build.dir}/${ant.project.name}/${hcatalog.core.jar}" 164 basedir="${build.classes}"/> 175 <target name="server-extensions" depends="compile-src"> 176 <jar jarfile="${build.dir}/${ant.project.name}/${ant.project.name}-server-extensions-${hcatalog.version}.jar" 177 basedir="${build.classes}" 178 includes="org/apache/hcatalog/listener/**,org/apache/hcatalog/metadata/**"/> - Travis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6494/#review11224 ----------------------------------------------------------- On Aug. 31, 2012, 10:34 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6494/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2012, 10:34 p.m.) > > > Review request for hcatalog and Francis Liu. > > > Description > ------- > > hcatalog-server-extensions.jar is an existing artifact we provide. This > change refactors the repo layout & build so that server-extensions is a new > subproject with its own Ivy dependencies. > > The benefit is users who do not need the server extensions do not pull JMS & > other transitive dependencies into their project. > > > This addresses bug HCATALOG-461. > https://issues.apache.org/jira/browse/HCATALOG-461 > > > Diffs > ----- > > ant/deploy.xml 84c3648 > build-common.xml ac9b4f5 > build.xml 76b8cb4 > hcatalog-pig-adapter/build.xml 8dbc319 > ivy.xml 11e45bf > server-extensions/build.xml PRE-CREATION > server-extensions/pom.xml PRE-CREATION > > server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java > PRE-CREATION > > server-extensions/src/test/java/org/apache/hcatalog/listener/TestMsgBusConnection.java > PRE-CREATION > > server-extensions/src/test/java/org/apache/hcatalog/listener/TestNotificationListener.java > PRE-CREATION > src/java/org/apache/hcatalog/listener/NotificationListener.java 8529c5a > src/test/org/apache/hcatalog/listener/TestMsgBusConnection.java 4da3cef > src/test/org/apache/hcatalog/listener/TestNotificationListener.java 7d09d79 > webhcat/java-client/build.xml fc1386c > webhcat/svr/build.xml a7bc34c > > Diff: https://reviews.apache.org/r/6494/diff/ > > > Testing > ------- > > > Thanks, > > Travis Crawford > >
