> On Sept. 19, 2012, 5:25 p.m., Francis Liu wrote:
> > Ship It!
>
> Francis Liu wrote:
> Nitpick: a lot of the generated poms look like this:
> "webhcat-java-client-\$\{hcatalog.version\}.pom" it'd be nice if we could fix
> that on commit. Tho it's not a big deal since this is going away.
Good catch. I believe this was an error that got introduced rebasing the patch.
Instead of:
<property name="pom.file"
location="${basedir}/ivy/${ant.project.name}-${hcatalog.version}.pom"/>
We should have put these inside build.dir:
<property name="pom.file"
location="${build.dir}/ivy/${ant.project.name}-${hcatalog.version}.pom"/>
I made this small change in the subprojects and checked this in.
Unless there's a good reason not to, the build should always generate files
inside the build dir, so that clean removes it.
Thanks for the review!
- Travis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6494/#review11704
-----------------------------------------------------------
On Sept. 12, 2012, 11:47 p.m., Travis Crawford wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6494/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2012, 11:47 p.m.)
>
>
> Review request for hcatalog and Francis Liu.
>
>
> Description
> -------
>
> hcatalog-server-extensions.jar is an existing artifact we provide. This
> change refactors the repo layout & build so that server-extensions is a new
> subproject with its own Ivy dependencies.
>
> The benefit is users who do not need the server extensions do not pull JMS &
> other transitive dependencies into their project.
>
>
> This addresses bug HCATALOG-461.
> https://issues.apache.org/jira/browse/HCATALOG-461
>
>
> Diffs
> -----
>
> ant/deploy.xml 84c3648
> build-common.xml 8740772
> build.xml b7fc8a1
> hcatalog-pig-adapter/build.xml 8dbc319
> ivy.xml 11e45bf
> server-extensions/build.xml PRE-CREATION
> server-extensions/pom.xml PRE-CREATION
>
> server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java
> PRE-CREATION
>
> server-extensions/src/test/java/org/apache/hcatalog/listener/TestMsgBusConnection.java
> PRE-CREATION
>
> server-extensions/src/test/java/org/apache/hcatalog/listener/TestNotificationListener.java
> PRE-CREATION
> src/java/org/apache/hcatalog/listener/NotificationListener.java 5c6b8ad
> src/test/org/apache/hcatalog/listener/TestMsgBusConnection.java 0db2b16
> src/test/org/apache/hcatalog/listener/TestNotificationListener.java 9a66427
> webhcat/java-client/build.xml fc1386c
> webhcat/svr/build.xml a7bc34c
>
> Diff: https://reviews.apache.org/r/6494/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Travis Crawford
>
>
