Also, the patch seems to have removed the existing short-circuit read feature (HDFS-2246). It is an incompatible change. I think the patch is farther away from being ready and I would keep my -1.
Tsz-Wo ________________________________ From: Tsz Wo Sze <szets...@yahoo.com> To: "hdfs-dev@hadoop.apache.org" <hdfs-dev@hadoop.apache.org> Sent: Wednesday, February 20, 2013 11:56 AM Subject: Re: VOTE: HDFS-347 merge -1 The patch seems not ready yet. I have posted some comments/suggestions on the JIRA. Colin also has agreed that there are some bugs to be fixed. Sorry. Tsz-Wo ________________________________ From: Todd Lipcon <t...@cloudera.com> To: hdfs-dev@hadoop.apache.org Sent: Tuesday, February 19, 2013 4:11 PM Subject: Re: VOTE: HDFS-347 merge +1 (binding) I code-reviewed almost all of the code in this branch, and also spent some time benchmarking and testing under various workloads. We've also done significant testing on clusters here at Cloudera, both secure and insecure, and verified integration with a number of other ecosystem components (eg Pig, Hive, Impala, HBase, MR, etc). The feature works as advertised and should provide much better performance for a number of workloads, especially in secure environments. Thanks for the hard work, Colin! -Todd On Sun, Feb 17, 2013 at 1:48 PM, Colin McCabe <cmcc...@alumni.cmu.edu>wrote: > Hi all, > > I would like to merge the HDFS-347 branch back to trunk. It's been > under intensive review and testing for several months. The branch > adds a lot of new unit tests, and passes Jenkins as of 2/15 [1] > > We have tested HDFS-347 with both random and sequential workloads. The > short-circuit case is substantially faster [2], and overall > performance looks very good. This is especially encouraging given > that the initial goal of this work was to make security compatible > with short-circuit local reads, rather than to optimize the > short-circuit code path. We've also stress-tested HDFS-347 on a > number of clusters. > > This iniial VOTE is to merge only into trunk. Just as we have done > with our other recent merges, we will consider merging into branch-2 > after the code has been in trunk for few weeks. > > Please cast your vote by EOD Sunday 2/24. > > best, > Colin McCabe > > [1] > https://issues.apache.org/jira/browse/HDFS-347?focusedCommentId=13579704&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13579704 > > [2] > https://issues.apache.org/jira/browse/HDFS-347?focusedCommentId=13551755&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13551755 > -- Todd Lipcon Software Engineer, Cloudera
