[
https://issues.apache.org/jira/browse/HDFS-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955936#comment-14955936
]
Jing Zhao commented on HDFS-9173:
---------------------------------
The patch looks pretty good to me. Some comments:
# The current patch extends the {{initReplicaRecovery}} protocol with a new
{{onlyCheck}} parameter. Another way is to add a new method in
{{InterDatanodeProtocol}} for getting the replica information. Currently I
prefer the later and feels maybe it's more clean.
# Besides the changes on {{initReplicaRecovery}}, other changes in
{{InterDatanodeProtocol}} is unnecessary.
# For recovery, the storage ID information originally on the NameNode side can
be inaccurate in the beginning, since during the write the DataNode may choose
a different storage. Thus the storage information reported back to NN in
{{commitBlockSynchronization}} should be based on the result of
{{updateReplicaUnderRecovery}}, and the changes on {{RecoveringBlock}}'s
constructor methods seem unnecessary.
# Maybe more unit tests on the {{getSafeLength}} method.
> Erasure Coding: Lease recovery for striped file
> -----------------------------------------------
>
> Key: HDFS-9173
> URL: https://issues.apache.org/jira/browse/HDFS-9173
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Walter Su
> Assignee: Walter Su
> Attachments: HDFS-9173.00.wip.patch, HDFS-9173.01.patch,
> HDFS-9173.02.step125.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
