[
https://issues.apache.org/jira/browse/HDFS-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959398#comment-14959398
]
Rakesh R commented on HDFS-9173:
--------------------------------
Awesome work [~walter.k.su], its really interesting. I've few comments:
# {{getSafeLength}} -> Could you please tell me the behavior of a file where it
doesn't have any block with full cell size of 64k. For example, all the blocks
having less than the CELL_SIZE number of bytes. Say CELL_SIZE=64 * 1024, now
blocks are blk1=1024 blk2=2*1024 blk3=3*1024 blk4=4*1024 blk5=5*104 blk6=6*1024
number of bytes etc. Please add a test if not included.
# The patch is quite large, just a suggestion to simplify the review & patch
rework effort. I could see you have created {{BlockRecoveryWorker}},
{{RecoveryTask}} classes to segregate the logic and done few improvements. Its
nice idea. If everyone agrees, it would be good to create another jira to do
these pre-requisite changes separately and can safely push it within no time.
Later in this jira, will do focused review/test for the
{{StripedRecoveryTask#recover()}} related logic. Any thoughts?
> Erasure Coding: Lease recovery for striped file
> -----------------------------------------------
>
> Key: HDFS-9173
> URL: https://issues.apache.org/jira/browse/HDFS-9173
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Walter Su
> Assignee: Walter Su
> Attachments: HDFS-9173.00.wip.patch, HDFS-9173.01.patch,
> HDFS-9173.02.step125.patch, HDFS-9173.03.patch, HDFS-9173.04.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
