[ https://issues.apache.org/jira/browse/HDFS-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958058#comment-14958058 ]
Jing Zhao commented on HDFS-9173: --------------------------------- Thanks for updating the patch, Walter. Some minors on the latest patch: # The label of {{ecPolicy}} should be 4. {code} optional BlockProto truncateBlock = 3; // New block for recovery (truncate) + + optional ErasureCodingPolicyProto ecPolicy = 5; {code} # BlockRecord does not need to be public # We can have more unit tests to cover different combinations of replica states (Finalized, Rbw, etc.) and lengths. Some tests with randomness can also help. This can be done in a separate jira. > Erasure Coding: Lease recovery for striped file > ----------------------------------------------- > > Key: HDFS-9173 > URL: https://issues.apache.org/jira/browse/HDFS-9173 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Walter Su > Assignee: Walter Su > Attachments: HDFS-9173.00.wip.patch, HDFS-9173.01.patch, > HDFS-9173.02.step125.patch, HDFS-9173.03.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)