[ https://issues.apache.org/jira/browse/HDFS-9173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960162#comment-14960162 ]
Zhe Zhang commented on HDFS-9173: --------------------------------- bq. #2. about syncBlockFinalized, syncBlockUnfinalized. bq. Unfortunately, The logic isn't quite the same between contiguous and striped. For example, I meant that {{syncBlockFinalized}} is only for contiguous blocks (in the code snippet it only appears in {{RecoveryTaskContiguous}}). The logic of syncing unfinalized replicas in {{RecoveryTaskContiguous}} (RWR, RBW) is very similar to syncing striped internal blocks. So ideally {{RecoveryTaskContiguous}} and {{RecoveryTaskStriped}} should share a {{syncBlockUnfinalized}} method (it appears in both {{RecoveryTaskContiguous}} and {{RecoveryTaskStriped}} in the code snippet). > Erasure Coding: Lease recovery for striped file > ----------------------------------------------- > > Key: HDFS-9173 > URL: https://issues.apache.org/jira/browse/HDFS-9173 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Walter Su > Assignee: Walter Su > Attachments: HDFS-9173.00.wip.patch, HDFS-9173.01.patch, > HDFS-9173.02.step125.patch, HDFS-9173.03.patch, HDFS-9173.04.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)