[ 
https://issues.apache.org/jira/browse/HDFS-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025149#comment-15025149
 ] 

Mingliang Liu commented on HDFS-9457:
-------------------------------------

Thanks for working on this.

{{DataNode}} has adopted the slf4j logger. For parameters, we should remove all 
unnecessary string concatenation and use placeholders instead. Meanwhile, we 
should remove guards when calling {{LOG.debug()}} and {{LOG.trace()}}. Please 
refer to [HDFS-8971] for an example.

> Datanode Logging Improvement
> ----------------------------
>
>                 Key: HDFS-9457
>                 URL: https://issues.apache.org/jira/browse/HDFS-9457
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 3.0.0, 2.7.0
>            Reporter: BELUGA BEHR
>            Priority: Trivial
>         Attachments: Logging.diff
>
>
> Please accept my patch for some minor clean-up of logging. Patch is against 
> 3.0.0 but applies to previous versions as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to