[ 
https://issues.apache.org/jira/browse/HDFS-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027834#comment-15027834
 ] 

Mingliang Liu commented on HDFS-9457:
-------------------------------------

Thanks for updating the patch.

Please refer to page at: http://www.slf4j.org/faq.html#paramException

Please address the logging format only in the patch. I see little value in 
changes here like:
{code}
-  public void reconfigurePropertyImpl(String property, String newVal)
+  public void reconfigurePropertyImpl(final String property, final String 
newVal)
{code}

> Datanode Logging Improvement
> ----------------------------
>
>                 Key: HDFS-9457
>                 URL: https://issues.apache.org/jira/browse/HDFS-9457
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 3.0.0, 2.7.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: logging.patch
>
>
> Please accept my patch for some minor clean-up of logging. Patch is against 
> 3.0.0 but applies to previous versions as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to