[ 
https://issues.apache.org/jira/browse/HDFS-9457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026160#comment-15026160
 ] 

BELUGA BEHR commented on HDFS-9457:
-----------------------------------

Would you prefer option 1 or option 2? :)

{code}
if (info != null) {
   // TRACE MSG 1
} else {
  // TRACE MS 2
}
{code}

{code}
if (LOG.isTraceEnabled())
{
  if (info != null) {
    // TRACE MSG 1
  } else {
    // TRACE MS 2
  }
}
{code}

> Datanode Logging Improvement
> ----------------------------
>
>                 Key: HDFS-9457
>                 URL: https://issues.apache.org/jira/browse/HDFS-9457
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 3.0.0, 2.7.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: Logging.diff
>
>
> Please accept my patch for some minor clean-up of logging. Patch is against 
> 3.0.0 but applies to previous versions as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to