[ https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388932#comment-16388932 ]
Íñigo Goiri commented on HDFS-13226: ------------------------------------ Thanks [~maobaolong] for the examples; that makes sense. I would go for your first proposal, switching to exceptions might be too disruptive. The only thing, is you should probably still do the check: {code} if (this.getDestinations() == null || this.getDestinations().size() == 0) { LOG.error("Invalid entry, no destination paths specified ", this); return false; } {code} > RBF: We should throw the failure validate and refuse this mount entry > --------------------------------------------------------------------- > > Key: HDFS-13226 > URL: https://issues.apache.org/jira/browse/HDFS-13226 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs > Affects Versions: 3.2.0 > Reporter: maobaolong > Assignee: maobaolong > Priority: Major > Labels: RBF > Fix For: 3.2.0 > > Attachments: HDFS-13226.001.patch > > > one of the mount entry source path rule is that the source path must start > with '\', somebody didn't follow the rule and execute the following command: > {code:bash} > $ hdfs dfsrouteradmin -add addnode/ ns1 /addnode/ > {code} > But, the console show we are successful add this entry. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org