[ 
https://issues.apache.org/jira/browse/HDFS-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453415#comment-13453415
 ] 

Suresh Srinivas commented on HDFS-2656:
---------------------------------------

bq. Hey Suresh. Not speaking for Colin, but regarding my comment above: I 
thought this JIRA was committed rather abruptly. 
Todd, the patch in its various forms has been making progress for a very long 
time. I agree that this is a big patch. Anybody who wants to review could just 
post a comment saying can please hold this for review.

But agreed, perhaps, before committing we could have posted a comment saying 
does anyone have any comments. 

Also one could come back and comment on this jira with further comments. We 
could then create further jiras. Given Jing has spent quite a lot of time on it 
and his expertise is more around java than c, addressing comments was a nice 
way for him to understand this part of the code better. But that said, he could 
look at cleanups to understand what is expected in these modules.

bq. Maybe we should have some kind of policy that, for large patches like this, 
committers should wait a day or two between giving a +1 and committing, in case 
others want to review? I don't think it's really necessary, but maybe it's 
better than post-commit review in a followup, or asking for a revert in the 
same JIRA.

+1 for the idea. We do not need a rule for this. Committer could just follow 
this in practice. Also interested folks could just post a comment to hold the 
commit until review (in a reasonable timeframe). 
                
> Implement a pure c client based on webhdfs
> ------------------------------------------
>
>                 Key: HDFS-2656
>                 URL: https://issues.apache.org/jira/browse/HDFS-2656
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: webhdfs
>            Reporter: Zhanwei.Wang
>            Assignee: Jing Zhao
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-2656.patch, HDFS-2656.patch, HDFS-2656.patch, 
> HDFS-2656.unfinished.patch, teragen_terasort_teravalidate_performance.png
>
>
> Currently, the implementation of libhdfs is based on JNI. The overhead of JVM 
> seems a little big, and libhdfs can also not be used in the environment 
> without hdfs.
> It seems a good idea to implement a pure c client by wrapping webhdfs. It 
> also can be used to access different version of hdfs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to