HI,

this is terrific news!

On Sun, Mar 24, 2013 at 7:18 PM, Beniamino Galvani <[email protected]> wrote:
> The UART driver was copied from ARM926 with minor changes and I think
> that we should evaluate if it's possible to merge the two. The next
> steps should consists in improving some parts (like interrupts
> handling and system timer), cleaning the code and in the future maybe
> adding support for USB, ethernet or external display.

I have not studied the broadcom manual, do you know if the USB HC is a
standard EHCI controller, with some USB OTG sauce or something
special?
AFAIK ethernet is provided by USB ethernet adapter. A driver for USB
communication device class would be a great addition :)

>
> Please let me know if you have any comments, suggestions or feedback.

I scanned the diff and it looks good. It's good to see that no major
changes in generic code were necessary, it looks like even boot time
caches work :)

One nitpick:
Enabling extended memory model (bit23 sctlr) should be moved to
cpu_arch_init (kernel/arch/arm32/src/cpu/cpu.c).
bit 23 is RAO/SBOP on armv7 so it's ok to put it in the ifdef armv6/v7 block.

thanks
jan

>
> Beniamino
>
> _______________________________________________
> HelenOS-devel mailing list
> [email protected]
> http://lists.modry.cz/cgi-bin/listinfo/helenos-devel

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel

Reply via email to