Hi,

>> One nitpick:
>> Enabling extended memory model (bit23 sctlr) should be moved to
>> cpu_arch_init (kernel/arch/arm32/src/cpu/cpu.c).
>> bit 23 is RAO/SBOP on armv7 so it's ok to put it in the ifdef armv6/v7 block.
>
> Since bit 23 selects the page table format, it must be set before the
> kernel switches to new page tables in page_init(). But cpu_arch_init()
> is called after page_init(), so the initialization there is
> uneffective.

yeah, good point. I still think it's more of a cpu/arch option than mm,
but as I said, it's minor, it can be moved later if we find a better place.

jan

>
> Beniamino
>
> _______________________________________________
> HelenOS-devel mailing list
> [email protected]
> http://lists.modry.cz/cgi-bin/listinfo/helenos-devel

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel

Reply via email to