2013/3/25 Ján Veselý <[email protected]>:
> I have not studied the broadcom manual, do you know if the USB HC is a
> standard EHCI controller, with some USB OTG sauce or something
> special?
> AFAIK ethernet is provided by USB ethernet adapter. A driver for USB
> communication device class would be a great addition :)

Hi Jan,
I've completely skipped the USB part in the datasheet, so I don't know
if the controller is a standard one, but this is definitely something
to look into after we get the basic system to work.

>>
>> Please let me know if you have any comments, suggestions or feedback.
>
> I scanned the diff and it looks good. It's good to see that no major
> changes in generic code were necessary, it looks like even boot time
> caches work :)

I was surprised of that too. This means that the generic code is well written :)

> One nitpick:
> Enabling extended memory model (bit23 sctlr) should be moved to
> cpu_arch_init (kernel/arch/arm32/src/cpu/cpu.c).
> bit 23 is RAO/SBOP on armv7 so it's ok to put it in the ifdef armv6/v7 block.

Since bit 23 selects the page table format, it must be set before the
kernel switches to new page tables in page_init(). But cpu_arch_init()
is called after page_init(), so the initialization there is
uneffective.

Beniamino

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/cgi-bin/listinfo/helenos-devel

Reply via email to