On Tue, 14 Dec 1999, Gilles Detillieux wrote:

> Date: Tue, 14 Dec 1999 15:37:02 -0600 (CST)
> From: Gilles Detillieux <[EMAIL PROTECTED]>
> To: "Joe R. Jah" <[EMAIL PROTECTED]>
> Cc: [EMAIL PROTECTED], [EMAIL PROTECTED]
> Subject: Re: max_keywords works as expected;)
> 
> Oops.  If you're going to add a line to a patch, you need to bump up the
> line count for that section, in this case from 36 to 37.  You may also
> want to remove the now inappropriate sentence...
> 
>    I removed the "return TRUE;"
>    after the visited.Add() call, which would have caused a memory leak as it
>    didn't delete the local_filename at that point.

Done;)

> This was a poorly thought out last minute change.  I keep forgetting that
> when you add a string to a Dictionary, you can't delete it afterward.  Of
> course there was no memory leak there before, and my change broke the code.
> Sorry about that.

That reminds me; you have added +#include <sys/types.h> to the original
patch; I took it out and everything worked fine.  Is there any reason it
should be there?

Regards,

Joe
-- 
     _/   _/_/_/       _/              ____________    __o
     _/   _/   _/      _/         ______________     _-\<,_
 _/  _/   _/_/_/   _/  _/                     ......(_)/ (_)
  _/_/ oe _/   _/.  _/_/ ah        [EMAIL PROTECTED]


------------------------------------
To unsubscribe from the htdig3-dev mailing list, send a message to
[EMAIL PROTECTED] 
You will receive a message to confirm this. 

Reply via email to