Is this code clear? How can we improve the comments? Have we considered all of the edge cases?
Is there a better way to do this? How easy will it be to extend this? -- Shmuel (Seymour J.) Metz http://mason.gmu.edu/~smetz3 עַם יִשְׂרָאֵל חַי נֵ֣צַח יִשְׂרָאֵ֔ל לֹ֥א יְשַׁקֵּ֖ר ________________________________________ From: IBM Mainframe Discussion List <IBM-MAIN@LISTSERV.UA.EDU> on behalf of Colin Paice <0000059d4daca697-dmarc-requ...@listserv.ua.edu> Sent: Sunday, March 17, 2024 10:42 AM To: IBM-MAIN@LISTSERV.UA.EDU Subject: Re: Learning one's tools I think code reviews are very useful, especially for not yet experts. It is good education for all levels. We had reviews, and comments like - Do you need a latch across these instructions for when there is concurrent execution? - If it abends here, how will the frr code ... - Would it help capturing foot prints to show how we got here, before the following code which may abend. - Some customers will not send us a dump, so we need to capture as much as we can in registers. Colin On Sun, 17 Mar 2024 at 13:40, Bob Bridges < 00000587168ababf-dmarc-requ...@listserv.ua.edu> wrote: > I suppose code reviews are like post-battle debriefs, in which every > choice of the commander is questioned, and when challenged with a better > option he can only say "I didn't think of that at the time". It must be > extremely painful for the guy in the glare of the spotlight, but if it's > done right -- too late to blame anyone now, we're just trying to make sure > everyone has a chance to learn how to do it better next time -- it's also > extremely valuable. I truly hated having the code reviewers poke at my > baby, and at the start of this thread I pointed out ways in which they > didn't do it right. But I agree with Shmuel, when done right you might > even say they're necessary. > > (And post-surgical reviews, too. The patient lived, or the patient died, > fine, but now we want to know what to do differently next time.) > > --- > Bob Bridges, robhbrid...@gmail.com, cell 336 382-7313 > > /* The kingdom of Heaven is not for the well-meaning; it is for the > desperate. -James Denney (1856-1917) */ > > -----Original Message----- > From: IBM Mainframe Discussion List <IBM-MAIN@LISTSERV.UA.EDU> On Behalf > Of Seymour J Metz > Sent: Sunday, March 17, 2024 00:41 > > However, disagree vehemently about "Code reviews are dumb and not needed > by good programmers." The first two things that a good programmer learns > are that nobody has a monopoly on good ideas and that "Even Jove nods". > Code reviews are like auditors and tech writers: when they are good they > are very very good, and when they are bad they are horrid. > > ---------------------------------------------------------------------- > For IBM-MAIN subscribe / signoff / archive access instructions, > send email to lists...@listserv.ua.edu with the message: INFO IBM-MAIN > ---------------------------------------------------------------------- For IBM-MAIN subscribe / signoff / archive access instructions, send email to lists...@listserv.ua.edu with the message: INFO IBM-MAIN ---------------------------------------------------------------------- For IBM-MAIN subscribe / signoff / archive access instructions, send email to lists...@listserv.ua.edu with the message: INFO IBM-MAIN
