The difference is that you not only learn how to do it better next time, you get to improve it this time. Taking ownership doesn't mean keeping people off your turf; a professional should always be open to informed criticism.
I've exchanged code with a number of people over the years, and have always been glad when they've showed me a better way to do something. Sometimes you can even learn from your students. -- Shmuel (Seymour J.) Metz http://mason.gmu.edu/~smetz3 עַם יִשְׂרָאֵל חַי נֵ֣צַח יִשְׂרָאֵ֔ל לֹ֥א יְשַׁקֵּ֖ר ________________________________________ From: IBM Mainframe Discussion List <IBM-MAIN@LISTSERV.UA.EDU> on behalf of Bob Bridges <00000587168ababf-dmarc-requ...@listserv.ua.edu> Sent: Sunday, March 17, 2024 9:40 AM To: IBM-MAIN@LISTSERV.UA.EDU Subject: Re: Learning one's tools I suppose code reviews are like post-battle debriefs, in which every choice of the commander is questioned, and when challenged with a better option he can only say "I didn't think of that at the time". It must be extremely painful for the guy in the glare of the spotlight, but if it's done right -- too late to blame anyone now, we're just trying to make sure everyone has a chance to learn how to do it better next time -- it's also extremely valuable. I truly hated having the code reviewers poke at my baby, and at the start of this thread I pointed out ways in which they didn't do it right. But I agree with Shmuel, when done right you might even say they're necessary. (And post-surgical reviews, too. The patient lived, or the patient died, fine, but now we want to know what to do differently next time.) --- Bob Bridges, robhbrid...@gmail.com, cell 336 382-7313 /* The kingdom of Heaven is not for the well-meaning; it is for the desperate. -James Denney (1856-1917) */ -----Original Message----- From: IBM Mainframe Discussion List <IBM-MAIN@LISTSERV.UA.EDU> On Behalf Of Seymour J Metz Sent: Sunday, March 17, 2024 00:41 However, disagree vehemently about "Code reviews are dumb and not needed by good programmers." The first two things that a good programmer learns are that nobody has a monopoly on good ideas and that "Even Jove nods". Code reviews are like auditors and tech writers: when they are good they are very very good, and when they are bad they are horrid. ---------------------------------------------------------------------- For IBM-MAIN subscribe / signoff / archive access instructions, send email to lists...@listserv.ua.edu with the message: INFO IBM-MAIN ---------------------------------------------------------------------- For IBM-MAIN subscribe / signoff / archive access instructions, send email to lists...@listserv.ua.edu with the message: INFO IBM-MAIN
