I think Lars has a point ... maybe set_include_path() could be given a second parameter instead to mitigate the need for seperate funcs?:
set_include_path('foo', INCPATH_OVERRIDE); // default
set_include_path('foo', INCPATH_APPEND);
set_include_path('foo', INCPATH_PREPEND);
Strojny schreef:
Hi Pierre, Am Mittwoch, den 13.02.2008, 23:01 +0100 schrieb Pierre Joye: [...]the following patch[1] adds the functions append_include_path() and prepend_include_path(). These function are there to make include path adjustments easier than it is. Especially append_include_path() is what is done most of the time.[...]I don't think we need two new functions for:Sure?set_include_path('/some/path' . DIRECTORY_SEPARATOR . get_include_path());See: prepend_include_path('/some/path');set_include_path(. get_include_path() . DIRECTORY_SEPARATOR . '/some/path' );See: append_include_path('/some/path'); Think about reading the code. What's easier to grasp for you? Introducing this functions is meant to make a) code better readable, b) easier to write the code, as most of the time, include path adjustments are include path appends, so the roundtrip set_include_path(get_include_path() ...) is not suboptimal. On the other hand, introducing this functions will not very likely introduce a lot of new bugs, so the maintenance overhead is lower than the value this functions bring (of course this is my POV, as I wrote that patch :-)). And, for the record, I promise to provide fixes for each the related bug (everyone heard that?). cu, Lars
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
