On 11/25/10 10:33 AM, Andi Gutmans wrote: >> -----Original Message----- >> From: Rasmus Lerdorf [mailto:ras...@lerdorf.com] >> Sent: Thursday, November 25, 2010 10:26 AM >> To: Ilia Alshanetsky >> Cc: Johannes Schlüter; Andi Gutmans; Jani Taskinen; da...@php.net; PHP >> Internals >> Subject: Re: [PHP-DEV] Re: Hold off 5.4 >> >> We also need that non-null zend_parse_parameters type implemented to clean >> up the null-byte poisoning fixes in 5.3. I can't see this slowing us down >> much as >> it is pretty trivial. Just takes someone to sit down for a couple of hours >> and >> implementing it and finding all the places where parameters end up in paths. >> There are probably other places we don't want nulls either that currently >> have >> local checks that can be removed. > > Yes I agree. We may be able to skip this check for interned strings which > would be nice and potentially eliminate performance impact somewhat but it's > something that would need to be looked into. It's non-trivial but doable > (need to add a flag for interned strings whether they have a zero byte or > not).
I'm not too worried about the performance impact here. Functions that need these non-null strings need them because they are about to access the file system in some way. The time it takes to check for nulls compared to the file system access time is so small that I think we can safely ignore performance issues. -R -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
