Hi Tjerk, 2013/6/27 Tjerk Meesters <tjerk.meest...@gmail.com>
> The thread started with the assertion that it raises a warning and the > commits first remove the warning and then adds it again later, so isn't the > whole PR a noop? :) The issue is inconsistent behavior of hex2bin against invalid inputs. Both removing and adding E_WARNING provide consistency. Adding E_WARNING is better than removing as a result discussion, IMO. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.netHi