[
https://issues.apache.org/jira/browse/ARTEMIS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903823#comment-15903823
]
ASF GitHub Bot commented on ARTEMIS-1011:
-----------------------------------------
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1081
ARTEMIS-1011 adjust slow-consumer detection logic
Adjust slow-consumer detection logic to use the number of messages in
the queue and not just the number of messages added since the last
check. This means the getRate() method now returns the rate of messages
which it *could* have dispatched since the last check rather than the
rate at which it received messages. This is a more reliable metric to
ensure the slow-consumer detection logic doesn't flag a consumer as
slow unfairly. Althoug the reliability will come at a performance cost
since getMessageCount() must lock the queue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1011
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1081
----
commit 85ddb298bc97a4caddd1cedbfad8d03eb8a725da
Author: Justin Bertram <jbert...@apache.org>
Date: 2017-03-09T14:11:00Z
ARTEMIS-1011 adjust slow-consumer detection logic
Adjust slow-consumer detection logic to use the number of messages in
the queue and not just the number of messages added since the last
check. This means the getRate() method now returns the rate of messages
which it *could* have dispatched since the last check rather than the
rate at which it received messages. This is a more reliable metric to
ensure the slow-consumer detection logic doesn't flag a consumer as
slow unfairly. Althoug the reliability will come at a performance cost
since getMessageCount() must lock the queue.
----
> Slow consumer detection - producer msg/s rate for queue should take into
> account messages which are already in queue
> --------------------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-1011
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1011
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.5.3
> Reporter: Miroslav Novak
> Fix For: 1.5.5, 2.0.0
>
>
> There is still a problem how producer msg/s rate is calculated in
> {{QueueImpl.getRate()}} for slow consumer detection. It calculates only
> messages added during the last slow consumer check period. As this is used to
> figure out, in which msg/s rate the queue could serve the consumer then it
> should also take into account messages which are already in queue at the
> start of queueRateCheckTime period.
> Current implementation is problem for cases when messages are sent to queue
> in bursts, for example producer sends 1000s messages in a few seconds and
> then stops and will do that again in 1 hour. QueueImpl.getRate() method
> returns 0 msg/s for slow consumer check period set to for example 5 min and
> slow consumer detection will be skipped.
> I tried to fix it by following change to QueueImpl.getRate() method and seems
> to be ok, wdyt?
> {code}
> private final AtomicLong messageCountSnapshot = new AtomicLong(0);
> public float getRate() {
> long locaMessageAdded = getMessagesAdded();
> float timeSlice = ((System.currentTimeMillis() -
> queueRateCheckTime.getAndSet(System.currentTimeMillis())) / 1000.0f);
> if (timeSlice == 0) {
> messagesAddedSnapshot.getAndSet(locaMessageAdded);
> return 0.0f;
> }
> return BigDecimal.valueOf(((locaMessageAdded -
> messagesAddedSnapshot.getAndSet(locaMessageAdded)) +
> messageCountSnapshot.getAndSet(getMessageCount())) / timeSlice).setScale(2,
> BigDecimal.ROUND_UP).floatValue();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
