[jira] [Commented] (ARTEMIS-1011) Slow consumer detection - producer msg/s rate for queue should take into account messages which are already in queue

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ARTEMIS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903877#comment-15903877
 ] 

ASF GitHub Bot commented on ARTEMIS-1011:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1081#discussion_r105275625
  
    --- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/SlowConsumerTest.java
 ---
    @@ -244,6 +245,49 @@ public void testSlowConsumerSpared() throws Exception {
        }
     
        @Test
    +   public void testSlowConsumerWithBurst() throws Exception {
    +      ClientSessionFactory sf = createSessionFactory(locator);
    +
    +      ClientSession session = addClientSession(sf.createSession(true, 
true));
    +
    +      ClientProducer producer = 
addClientProducer(session.createProducer(QUEUE));
    +
    +      final int numMessages = 20;
    +
    +      for (int i = 0; i < numMessages; i++) {
    +         producer.send(createTextMessage(session, "m" + i));
    +      }
    +
    +      assertPaging();
    +
    +      final Queue queue = server.locateQueue(QUEUE);
    +
    +      queue.getRate();
    +
    +      logger.info("Creating consumer...");
    +
    +      ClientConsumer consumer = 
addClientConsumer(session.createConsumer(QUEUE));
    +      session.start();
    +
    +      Wait.waitFor(new Wait.Condition() {
    +         @Override
    +         public boolean isSatisfied() throws Exception {
    +            forceGC();
    --- End diff --
    
    was this needed? forceGC is heavy


> Slow consumer detection - producer msg/s rate for queue should take into 
> account messages which are already in queue
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1011
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1011
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.5.3
>            Reporter: Miroslav Novak
>             Fix For: 1.5.5, 2.0.0
>
>
> There is still a problem how producer msg/s rate is calculated in 
> {{QueueImpl.getRate()}} for slow consumer detection. It calculates only 
> messages added during the last slow consumer check period. As this is used to 
> figure out, in which msg/s rate the queue could serve the consumer then it 
> should also take into account messages which are already in queue at the 
> start of queueRateCheckTime period. 
> Current implementation is problem for cases when messages are sent to queue 
> in bursts, for example producer sends 1000s messages in a few seconds and 
> then stops and will do that again in 1 hour. QueueImpl.getRate() method 
> returns 0 msg/s for slow consumer check period set to for example 5 min and 
> slow consumer detection will be skipped. 
> I tried to fix it by following change to QueueImpl.getRate() method and seems 
> to be ok, wdyt?
> {code}
>    private final AtomicLong messageCountSnapshot = new AtomicLong(0);
>    public float getRate() {
>       long locaMessageAdded = getMessagesAdded();
>       float timeSlice = ((System.currentTimeMillis() - 
> queueRateCheckTime.getAndSet(System.currentTimeMillis())) / 1000.0f);
>       if (timeSlice == 0) {
>          messagesAddedSnapshot.getAndSet(locaMessageAdded);
>          return 0.0f;
>       }
>       return BigDecimal.valueOf(((locaMessageAdded - 
> messagesAddedSnapshot.getAndSet(locaMessageAdded)) + 
> messageCountSnapshot.getAndSet(getMessageCount())) / timeSlice).setScale(2, 
> BigDecimal.ROUND_UP).floatValue();
>    }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)