[
https://issues.apache.org/jira/browse/ARTEMIS-5266?focusedWorklogId=954513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-954513
]
ASF GitHub Bot logged work on ARTEMIS-5266:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/25 17:21
Start Date: 29/Jan/25 17:21
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934293241
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java:
##########
@@ -216,8 +216,8 @@ public static org.apache.activemq.artemis.api.core.Message
inbound(final Message
}
final Object scheduledDelay =
messageSend.getProperties().get(ScheduledMessage.AMQ_SCHEDULED_DELAY);
- if (scheduledDelay instanceof Long) {
-
coreMessage.putLongProperty(org.apache.activemq.artemis.api.core.Message.HDR_SCHEDULED_DELIVERY_TIME,
System.currentTimeMillis() + ((Long) scheduledDelay));
+ if (scheduledDelay instanceof Long long1) {
Review Comment:
Something like delayMs or delayLong would be far more readable later.
Just about every name added below is equally unhelpful, and results in less
readable code than the original.
Issue Time Tracking
-------------------
Worklog Id: (was: 954513)
Time Spent: 2h 50m (was: 2h 40m)
> Code gardening after move to Java 17
> ------------------------------------
>
> Key: ARTEMIS-5266
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5266
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> With the recent move to Java 17 now is a good time to do some code gardening
> to leverage new language features (e.g. text blocks) and deal with old issue
> (e.g. unused variables, etc.).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
