[
https://issues.apache.org/jira/browse/ARTEMIS-3915?focusedWorklogId=982112&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-982112
]
ASF GitHub Bot logged work on ARTEMIS-3915:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/25 00:51
Start Date: 06/Sep/25 00:51
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2326317376
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/Connection.java:
##########
@@ -135,10 +135,25 @@ default void disconnect() {
}
/**
- * {@return the string representation of the remote address this connection
is connected to}
+ * {@return a string representation of the remote address of this
connection; if this connection is made via the
+ * proxy protocol then this will be the original address, not the proxy
address}
Review Comment:
I see your point, but if I were to do that I think I would also have to do
an `instanceof` in a lot of places since the `Connection` is what's passed
around on the broker in most places. I'm open to ideas, though.
FWIW, I did remove the proxy-related methods from `RemotingConnection`.
##########
tests/e2e-tests/pom.xml:
##########
@@ -220,6 +235,22 @@
<configuration>${basedir}/target/classes/servers/brokerConnect/qdr</configuration>
</configuration>
</execution>
+ <execution>
+ <phase>test-compile</phase>
+ <id>create-proxy</id>
Review Comment:
Done.
Issue Time Tracking
-------------------
Worklog Id: (was: 982112)
Time Spent: 2h 10m (was: 2h)
> Support PROXY Protocol
> ----------------------
>
> Key: ARTEMIS-3915
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3915
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: João Santos
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> [HAProxy|http://www.haproxy.org/] is a widely known and used TCP Load
> Balancer and especially useful for an ActiveMQ Artemis clustered environment.
> Although possible to functionally implement with both products current
> features, Artemis does not support the PROXY protocol, which prevents it's
> broker nodes from inferring the real remote client IP address when behind an
> HAProxy instance.
> Since Netty sockets implementation already seems to support this protocol
> (discussed w/ [~jbertram] on DEV mailing list), it shouldn't be a big leap to
> adding support for the protocol on Artemis acceptors, thus improving the
> deployment of the use case at hand.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
