[
https://issues.apache.org/jira/browse/ARTEMIS-3915?focusedWorklogId=982289&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-982289
]
ASF GitHub Bot logged work on ARTEMIS-3915:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/25 14:50
Start Date: 08/Sep/25 14:50
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2330494969
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerField.java:
##########
@@ -33,6 +33,8 @@ public enum ConsumerField {
CLIENT_ID("clientID"),
LOCAL_ADDRESS("localAddress"),
REMOTE_ADDRESS("remoteAddress"),
+ PROXY_ADDRESS("proxyAddress"),
+ PROXY_VERSION("proxyVersion"),
Review Comment:
Originally I only had the new fields on the connection, but then I saw that
`remoteAddress` was on the consumer & producer so I thought perhaps folks would
expect the new fields there as well.
I agree that repeating the fields across the different "views" is not ideal.
I'll remove them.
Issue Time Tracking
-------------------
Worklog Id: (was: 982289)
Time Spent: 3.5h (was: 3h 20m)
> Support PROXY Protocol
> ----------------------
>
> Key: ARTEMIS-3915
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3915
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: João Santos
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> [HAProxy|http://www.haproxy.org/] is a widely known and used TCP Load
> Balancer and especially useful for an ActiveMQ Artemis clustered environment.
> Although possible to functionally implement with both products current
> features, Artemis does not support the PROXY protocol, which prevents it's
> broker nodes from inferring the real remote client IP address when behind an
> HAProxy instance.
> Since Netty sockets implementation already seems to support this protocol
> (discussed w/ [~jbertram] on DEV mailing list), it shouldn't be a big leap to
> adding support for the protocol on Artemis acceptors, thus improving the
> deployment of the use case at hand.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
