[
https://issues.apache.org/jira/browse/ARTEMIS-3915?focusedWorklogId=982953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-982953
]
ASF GitHub Bot logged work on ARTEMIS-3915:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Sep/25 14:47
Start Date: 12/Sep/25 14:47
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2344483955
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java:
##########
@@ -215,7 +215,7 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf
in, List<Object> out) t
if (!protocolSet.isEmpty()) {
// Use getBytes(...) as this works with direct and heap buffers.
byte[] bytes = new byte[8];
- in.getBytes(0, bytes);
+ in.getBytes(in.readerIndex(), bytes);
Review Comment:
This was a left-over change that is unnecessary now.
Issue Time Tracking
-------------------
Worklog Id: (was: 982953)
Time Spent: 7h 50m (was: 7h 40m)
> Support PROXY Protocol
> ----------------------
>
> Key: ARTEMIS-3915
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3915
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: João Santos
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> [HAProxy|http://www.haproxy.org/] is a widely known and used TCP Load
> Balancer and especially useful for an ActiveMQ Artemis clustered environment.
> Although possible to functionally implement with both products current
> features, Artemis does not support the PROXY protocol, which prevents it's
> broker nodes from inferring the real remote client IP address when behind an
> HAProxy instance.
> Since Netty sockets implementation already seems to support this protocol
> (discussed w/ [~jbertram] on DEV mailing list), it shouldn't be a big leap to
> adding support for the protocol on Artemis acceptors, thus improving the
> deployment of the use case at hand.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
