[
https://issues.apache.org/jira/browse/ARTEMIS-3915?focusedWorklogId=982958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-982958
]
ASF GitHub Bot logged work on ARTEMIS-3915:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Sep/25 15:08
Start Date: 12/Sep/25 15:08
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2344551515
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/tests/util/CFUtil.java:
##########
@@ -26,13 +26,24 @@ public class CFUtil {
public static ConnectionFactory createConnectionFactory(String protocol,
String uri) {
if (protocol.toUpperCase().equals("OPENWIRE")) {
return new org.apache.activemq.ActiveMQConnectionFactory(uri);
+ } else if (protocol.toUpperCase().equals("OPENWIRE_SSL")) {
+ if (uri.startsWith("tcp://")) {
+ // replacing tcp:// by amqp://
Review Comment:
I simplified this code and removed the comment.
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/tests/util/CFUtil.java:
##########
@@ -26,13 +26,24 @@ public class CFUtil {
public static ConnectionFactory createConnectionFactory(String protocol,
String uri) {
if (protocol.toUpperCase().equals("OPENWIRE")) {
return new org.apache.activemq.ActiveMQConnectionFactory(uri);
+ } else if (protocol.toUpperCase().equals("OPENWIRE_SSL")) {
+ if (uri.startsWith("tcp://")) {
+ // replacing tcp:// by amqp://
+ uri = "ssl" + uri.substring(3);
+ }
+ return new org.apache.activemq.ActiveMQSslConnectionFactory(uri);
} else if (protocol.toUpperCase().equals("AMQP")) {
-
if (uri.startsWith("tcp://")) {
// replacing tcp:// by amqp://
uri = "amqp" + uri.substring(3);
}
return new JmsConnectionFactory(uri);
+ } else if (protocol.toUpperCase().equals("AMQPS")) {
+ if (uri.startsWith("tcp://")) {
+ // replacing tcp:// by amqp://
Review Comment:
Ditto.
Issue Time Tracking
-------------------
Worklog Id: (was: 982958)
Time Spent: 8h 10m (was: 8h)
> Support PROXY Protocol
> ----------------------
>
> Key: ARTEMIS-3915
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3915
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: João Santos
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> [HAProxy|http://www.haproxy.org/] is a widely known and used TCP Load
> Balancer and especially useful for an ActiveMQ Artemis clustered environment.
> Although possible to functionally implement with both products current
> features, Artemis does not support the PROXY protocol, which prevents it's
> broker nodes from inferring the real remote client IP address when behind an
> HAProxy instance.
> Since Netty sockets implementation already seems to support this protocol
> (discussed w/ [~jbertram] on DEV mailing list), it shouldn't be a big leap to
> adding support for the protocol on Artemis acceptors, thus improving the
> deployment of the use case at hand.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
