MarcoLugo commented on code in PR #3095:
URL: https://github.com/apache/avro/pull/3095#discussion_r1716874279
##########
lang/rust/avro/src/codec.rs:
##########
@@ -49,7 +49,13 @@ pub enum Codec {
/// CRC32 checksum of the uncompressed data in the block.
Snappy,
#[cfg(feature = "zstandard")]
+ /// The `Zstandard` codec uses Facebook's
[Zstandard](https://facebook.github.io/zstd/) with the
+ /// default compression level.
Zstandard,
+ #[cfg(feature = "zstandard")]
+ /// This codec is the same as `Zstandard` but allows specifying the
compression level.
+ #[strum(disabled)]
+ ZstandardWithLevel(ZstandardLevel),
Review Comment:
I added a similar struct for zstd but for now I ended up leaving out the
`dictionary` as it would be required for decoding as well and so it would need
to go into the header metadata and I'm not sure how to do that at the moment.
I'll need to read the avro spec in more detail, maybe this could be a future PR
in order to avoid blocking this one?
I also made the new settings structs public so they're visible in the docs
and can be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
