MarcoLugo commented on code in PR #3095:
URL: https://github.com/apache/avro/pull/3095#discussion_r1716888788
##########
lang/rust/avro/src/codec.rs:
##########
@@ -49,7 +49,13 @@ pub enum Codec {
/// CRC32 checksum of the uncompressed data in the block.
Snappy,
#[cfg(feature = "zstandard")]
+ /// The `Zstandard` codec uses Facebook's
[Zstandard](https://facebook.github.io/zstd/) with the
+ /// default compression level.
Zstandard,
+ #[cfg(feature = "zstandard")]
+ /// This codec is the same as `Zstandard` but allows specifying the
compression level.
+ #[strum(disabled)]
+ ZstandardWithLevel(ZstandardLevel),
Review Comment:
On second thought, maybe the dictionary option can still be provided and
left to the user for now without it necessarily being seamless (i.e. the dev is
responsible for providing it at both encoding and decoding time) if eventually
this can be made even more seamless by just being necessary at encoding time
then that's a nice bonus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
