martin-g commented on code in PR #3095:
URL: https://github.com/apache/avro/pull/3095#discussion_r1718199397
##########
lang/rust/avro/src/codec.rs:
##########
@@ -49,7 +49,13 @@ pub enum Codec {
/// CRC32 checksum of the uncompressed data in the block.
Snappy,
#[cfg(feature = "zstandard")]
+ /// The `Zstandard` codec uses Facebook's
[Zstandard](https://facebook.github.io/zstd/) with the
+ /// default compression level.
Zstandard,
+ #[cfg(feature = "zstandard")]
+ /// This codec is the same as `Zstandard` but allows specifying the
compression level.
+ #[strum(disabled)]
+ ZstandardWithLevel(ZstandardLevel),
Review Comment:
The dictionary is a Zstd thingy. It just needs to be the same for both
encoding and decoding.
Just pushed
https://github.com/apache/avro/pull/3095/commits/8f4a2f3c681d473a8dc62cd48aa5a93ff2e42e50
for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
