martin-g commented on code in PR #3095:
URL: https://github.com/apache/avro/pull/3095#discussion_r1718533682
##########
lang/rust/avro/src/codec.rs:
##########
@@ -183,6 +197,72 @@ impl Codec {
}
}
+#[cfg(feature = "bzip")]
+pub mod bzip {
+ use bzip2::Compression;
+
+ #[derive(Clone, Copy, Eq, PartialEq, Debug)]
+ pub struct Bzip2Settings {
Review Comment:
I wonder: do we need **Settings for each codec ?
All 3 classes are the same now.
If we need to add custom codec specific settings later it should not be a
big deal - the other codecs will just ignore any setting they don't support. I
do not expect many new settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
