[ 
https://issues.apache.org/jira/browse/BEAM-14240?focusedWorklogId=755405&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755405
 ]

ASF GitHub Bot logged work on BEAM-14240:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/22 19:33
            Start Date: 11/Apr/22 19:33
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] commented on PR #17340:
URL: https://github.com/apache/beam/pull/17340#issuecomment-1095479119

   # 
[Codecov](https://codecov.io/gh/apache/beam/pull/17340?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#17340](https://codecov.io/gh/apache/beam/pull/17340?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (626053f) into 
[master](https://codecov.io/gh/apache/beam/commit/5603bd310a63fa35082e6bc6b06c7fecc90e77d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (5603bd3) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #17340      +/-   ##
   ==========================================
   - Coverage   74.11%   74.10%   -0.02%     
   ==========================================
     Files         683      684       +1     
     Lines       89267    89322      +55     
   ==========================================
   + Hits        66164    66195      +31     
   - Misses      21950    21968      +18     
   - Partials     1153     1159       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | go | `50.15% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/17340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[sdks/go/pkg/beam/runners/dataflow/dataflow.go](https://codecov.io/gh/apache/beam/pull/17340/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93Lmdv)
 | `53.02% <ø> (+3.02%)` | :arrow_up: |
   | 
[.../pkg/beam/runners/dataflow/dataflowlib/messages.go](https://codecov.io/gh/apache/beam/pull/17340/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93bGliL21lc3NhZ2VzLmdv)
 | `0.00% <ø> (ø)` | |
   | 
[...pkg/beam/runners/dataflow/dataflowlib/translate.go](https://codecov.io/gh/apache/beam/pull/17340/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93bGliL3RyYW5zbGF0ZS5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[sdks/go/pkg/beam/io/databaseio/util.go](https://codecov.io/gh/apache/beam/pull/17340/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9kYXRhYmFzZWlvL3V0aWwuZ28=)
 | `56.75% <0.00%> (-5.41%)` | :arrow_down: |
   | 
[sdks/go/pkg/beam/io/synthetic/step.go](https://codecov.io/gh/apache/beam/pull/17340/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9zeW50aGV0aWMvc3RlcC5nbw==)
 | `81.53% <0.00%> (ø)` | |
   | 
[sdks/go/pkg/beam/util/pubsubx/pubsub.go](https://codecov.io/gh/apache/beam/pull/17340/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS91dGlsL3B1YnN1YngvcHVic3ViLmdv)
 | `50.76% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/17340?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/17340?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[5603bd3...626053f](https://codecov.io/gh/apache/beam/pull/17340?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 755405)
    Time Spent: 1h  (was: 50m)

> Address Staticcheck Warnings in the Go SDK
> ------------------------------------------
>
>                 Key: BEAM-14240
>                 URL: https://issues.apache.org/jira/browse/BEAM-14240
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Jack McCluskey
>            Priority: P2
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Clean up warnings from the staticcheck tool in the Go SDK with the aim of 
> eventually enabling staticcheck as a precommit. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to