[
https://issues.apache.org/jira/browse/BEAM-14240?focusedWorklogId=755446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755446
]
ASF GitHub Bot logged work on BEAM-14240:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/22 21:24
Start Date: 11/Apr/22 21:24
Worklog Time Spent: 10m
Work Description: lostluck commented on code in PR #17340:
URL: https://github.com/apache/beam/pull/17340#discussion_r847746921
##########
sdks/go/pkg/beam/runners/dataflow/dataflow.go:
##########
@@ -77,8 +77,7 @@ var (
teardownPolicy = flag.String("teardown_policy", "", "Job teardown
policy (internal only).")
// SDK options
- cpuProfiling = flag.String("cpu_profiling", "", "Job records CPU
profiles to this GCS location (optional)")
- sessionRecording = flag.String("session_recording", "", "Job records
session transcripts")
Review Comment:
Technically it's likely to fix the job unless it's been very small (outside
of breaking the flag being present).
The session runner's job was an honest hearted attempt to make SDK
development and bug finding easier by allowing playback of recorded job
features in the Early Portability age. These days, it's better if we have
clearer tools for that.
Issue Time Tracking
-------------------
Worklog Id: (was: 755446)
Time Spent: 2.5h (was: 2h 20m)
> Address Staticcheck Warnings in the Go SDK
> ------------------------------------------
>
> Key: BEAM-14240
> URL: https://issues.apache.org/jira/browse/BEAM-14240
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Priority: P2
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Clean up warnings from the staticcheck tool in the Go SDK with the aim of
> eventually enabling staticcheck as a precommit.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
