[
https://issues.apache.org/jira/browse/BEAM-14240?focusedWorklogId=755430&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755430
]
ASF GitHub Bot logged work on BEAM-14240:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/22 20:31
Start Date: 11/Apr/22 20:31
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on code in PR #17340:
URL: https://github.com/apache/beam/pull/17340#discussion_r847711123
##########
sdks/go/pkg/beam/runners/dataflow/dataflow.go:
##########
@@ -77,8 +77,7 @@ var (
teardownPolicy = flag.String("teardown_policy", "", "Job teardown
policy (internal only).")
// SDK options
- cpuProfiling = flag.String("cpu_profiling", "", "Job records CPU
profiles to this GCS location (optional)")
- sessionRecording = flag.String("session_recording", "", "Job records
session transcripts")
Review Comment:
We'll have to double-check this, but the sessionRecording flag currently
does nothing (hence the removed empty branch and removed flag) so I removed it.
But it is, technically, a breaking change since someone could be running
dataflow jobs with this flag set even though it doesn't do anything.
Issue Time Tracking
-------------------
Worklog Id: (was: 755430)
Time Spent: 2h (was: 1h 50m)
> Address Staticcheck Warnings in the Go SDK
> ------------------------------------------
>
> Key: BEAM-14240
> URL: https://issues.apache.org/jira/browse/BEAM-14240
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Priority: P2
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Clean up warnings from the staticcheck tool in the Go SDK with the aim of
> eventually enabling staticcheck as a precommit.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
