[
https://issues.apache.org/jira/browse/BEAM-14240?focusedWorklogId=755423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755423
]
ASF GitHub Bot logged work on BEAM-14240:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/22 20:17
Start Date: 11/Apr/22 20:17
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17340:
URL: https://github.com/apache/beam/pull/17340#discussion_r847699347
##########
sdks/go/pkg/beam/runners/session/session.go:
##########
@@ -135,6 +135,9 @@ func (c *controlServer) readSession(filename string) {
// Read out the entry header message.
b, err = br.Peek(int(l))
+ if err != nil {
+ panic(err)
Review Comment:
```suggestion
panic(errors.Wrap(err, "Problem peeking entry header
value"))
```
##########
sdks/go/pkg/beam/runners/vet/testpipeline/staticcheck.conf:
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+checks = ["inherit", "-U1000"]
Review Comment:
Is there a reason to have this file located in this testpipeline directory?
I suspect it is a config value that applies to the whole sdk and thus probably
belongs higher in the hierarchy (maybe at the `sdks/go` level?
Issue Time Tracking
-------------------
Worklog Id: (was: 755423)
Time Spent: 1h 20m (was: 1h 10m)
> Address Staticcheck Warnings in the Go SDK
> ------------------------------------------
>
> Key: BEAM-14240
> URL: https://issues.apache.org/jira/browse/BEAM-14240
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Clean up warnings from the staticcheck tool in the Go SDK with the aim of
> eventually enabling staticcheck as a precommit.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
