[
https://issues.apache.org/jira/browse/BEAM-8021?focusedWorklogId=302044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302044
]
ASF GitHub Bot logged work on BEAM-8021:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/19 14:49
Start Date: 27/Aug/19 14:49
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #9417: [BEAM-8021] Add
Automatic-Module-Name headers to beam's artifacts.
URL: https://github.com/apache/beam/pull/9417#issuecomment-525328195
I posted new fixes. Thanks to @iemejia 's comments I've read some more about
the topic (https://blog.joda.org/2017/04/java-se-9-jpms-module-naming.html) and
it turned out most of the names didn't adhere this rule:
> Module names are strongly recommended to be the same as the name of the
super-package.
Therefore, I changed the name wherever it was needed.
@iemejia, @kennknowles, @lukecwik could you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 302044)
Time Spent: 2h 50m (was: 2h 40m)
> Add Automatic-Module-Name headers for Beam Java modules
> --------------------------------------------------------
>
> Key: BEAM-8021
> URL: https://issues.apache.org/jira/browse/BEAM-8021
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Ismaël Mejía
> Assignee: Lukasz Gajowy
> Priority: Minor
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> For compatibility with the Java Platform Module System (JPMS) in Java 9 and
> later, every JAR should have a module name, even if the library does not
> itself use modules. As [suggested in the mailing
> list|https://lists.apache.org/thread.html/956065580ce049481e756482dc3ccfdc994fef3b8cdb37cab3e2d9b1@%3Cdev.beam.apache.org%3E],
> this is a simple change that we can do and still be backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
