[
https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615384#comment-16615384
]
Vladimir Sitnikov commented on CALCITE-2555:
--------------------------------------------
I was using https://github.com/apache/calcite/pull/831 commit
e2098d3073172b15882825bdc355755af1ae135e
Of course I've just added n = eq(n, falseLiteral); manually to one of the
existing tests in RexProgramTest.
{quote}I think it would be better to have it at least at the end of simplify_()
{quote}
While it might be logical to do that, allmost all of actions in simplify_ are
related to simplification of NON-strong nodes.
simplification of arguments to a strong functions is a separate thing which I
belive is not there.
> RexSimplify: >=(true, null) could be simplified to null
> -------------------------------------------------------
>
> Key: CALCITE-2555
> URL: https://issues.apache.org/jira/browse/CALCITE-2555
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Labels: newbie
>
> {code:java}
> @Test public void simplifyComparisonWithNull() {
> checkSimplify2(ge(trueLiteral, falseLiteral), "true", "true");
> checkSimplify2(ge(trueLiteral, nullBool), "null", "false");
> checkSimplify2(ge(nullBool, nullBool), "null", "false");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
