[
https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617183#comment-16617183
]
Vladimir Sitnikov commented on CALCITE-2555:
--------------------------------------------
{quote}it will not need a separate recursion anymore (because it could run with
the main recursion){quote}
I do not follow you.
1) You suggest to move simplifyStrong to the end of simplify_. That is somehow
understandable, however simplify_ has multiple returns, so do you suggest to
rewrite simplify_ method?
2) current simplify_ never "looks inside strong functions like LTRIM". What do
you mean by "main recursion" and how do you suggest to handle cases like
LTRIM(LTRIM(...)) ?
> RexSimplify: >=(true, null) could be simplified to null
> -------------------------------------------------------
>
> Key: CALCITE-2555
> URL: https://issues.apache.org/jira/browse/CALCITE-2555
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Labels: newbie
>
> {code:java}
> @Test public void simplifyComparisonWithNull() {
> checkSimplify2(ge(trueLiteral, falseLiteral), "true", "true");
> checkSimplify2(ge(trueLiteral, nullBool), "null", "false");
> checkSimplify2(ge(nullBool, nullBool), "null", "false");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
