[
https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616973#comment-16616973
]
Julian Hyde commented on CALCITE-2555:
--------------------------------------
Comments:
* The new method {{simplifyStrong}} needs a javadoc comment. It takes some
effort to figure out what it does.
* Is it safe to simplify a DECIMAL(7, 3) value to a DECIMAL(6, 4) value? I'm
not sure. So I think you need to consider precision and scale as well as
typeName. {{SqlTypeUtil.equalSansNullability}} may do what you need.
+1 when those are fixed
> RexSimplify: >=(true, null) could be simplified to null
> -------------------------------------------------------
>
> Key: CALCITE-2555
> URL: https://issues.apache.org/jira/browse/CALCITE-2555
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Labels: newbie
>
> {code:java}
> @Test public void simplifyComparisonWithNull() {
> checkSimplify2(ge(trueLiteral, falseLiteral), "true", "true");
> checkSimplify2(ge(trueLiteral, nullBool), "null", "false");
> checkSimplify2(ge(nullBool, nullBool), "null", "false");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
