[
https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615390#comment-16615390
]
Vladimir Sitnikov commented on CALCITE-2555:
--------------------------------------------
{quote} but you know...I'm just a nobody...just commit what you think is
right...{quote}
What do you mean by nobody?
Reviewing is an important process by the way, and people might be promoted to
committers by being a reviewer.
Contributions != code changes, and it is (almost) never too much review
comments.
{quote}I still think that adding it as an orthogonal logic is not the best
option.{quote}
1) PR 831 solves current issue
2) It is understandable
3) It has understandable impact (it recurses to simplifyStrong only, so there
shouldn't be lots of pathological cases in the wild)
4) It does not overcomplicate things (for instance, it does not rely on actual
literal comparisons, but it relies on {{null}} only which should be very
predictable)
5) We can always update it (which is called "refactor" or even "remove
incorrect optimization")
6) I think the proper way to fix "better to have it at least at the end of
simplify_() " and "adding it as an orthogonal logic is not the best option" is
CALCITE-2449, however that is completely separate discussion
> RexSimplify: >=(true, null) could be simplified to null
> -------------------------------------------------------
>
> Key: CALCITE-2555
> URL: https://issues.apache.org/jira/browse/CALCITE-2555
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Labels: newbie
>
> {code:java}
> @Test public void simplifyComparisonWithNull() {
> checkSimplify2(ge(trueLiteral, falseLiteral), "true", "true");
> checkSimplify2(ge(trueLiteral, nullBool), "null", "false");
> checkSimplify2(ge(nullBool, nullBool), "null", "false");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
