[
https://issues.apache.org/jira/browse/CALCITE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711291#comment-17711291
]
Stamatis Zampetakis commented on CALCITE-5615:
----------------------------------------------
Thanks for the PR [~mbudiu]!
Some high level comments/questions before I get down to a more detailed review:
I've noticed that currently the PR provides the means to run the tests but does
not actually run anything. It would be pretty helpful and valuable to also have
the logic that downloads and runs some of the SQL lite tests (those that pass).
In other words there should be some kind of unit/IT tests that can be launched
using {{./gradlew test}} or another similar directive. The runner is definitely
very useful but the most important part of this contribution is the amount of
additional tests that are going to be added and we should find a way to run
them regularly as part of the CI (frequency to be determined depending on the
duration).
Some files do not have the Apache AL2 license is this expected? We will need to
check if the respective license is problematic from an AL2 perspective.
I've seen that the new module will not be published to nexus as it is. Why is
that? Is it because of licensing or because it wouldn't make sense for other
consumers to use the runner?
Sonar has brought up some warnings/errors; please go over them and address
those that make sense.
> Run SQLLogicTests using Calcite
> -------------------------------
>
> Key: CALCITE-5615
> URL: https://issues.apache.org/jira/browse/CALCITE-5615
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.34.0
> Reporter: Mihai Budiu
> Assignee: Mihai Budiu
> Priority: Minor
>
> Sqllogictest is a program designed to verify that an SQL database engine
> computes correct results by comparing the results to identical queries from
> other SQL database engines.
> https://www.sqlite.org/sqllogictest/doc/trunk/about.wiki
> The nice thing about SLT is that it contains more than 7 million tests. The
> tests only cover the core of SQL, ideally the portable part across all
> engines. They only test integers, doubles, and strings. So they could
> probably be part of the Calcite slow tests.
> The tests should be structured so that any query execution engine can be used.
> I plan to contribute such an implementation if people think it is useful, but
> I haven't yet worked out all the details.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
